Improved assert to allow source location override #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JessyDL
force-pushed
the
feature/improved-assert
branch
4 times, most recently
from
f92437c
to
2d247f8
Compare
JessyDL
force-pushed
the
feature/improved-assert
branch
from
2d247f8
to
a7d8ac7
Compare
JessyDL
force-pushed
the
feature/improved-assert
branch
from
813494f
to
9932353
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a
std::source_locationwrapper to safely use source_location on all platforms (Android lacks an implementation)As well as adding the ability to override the source_location in the printing (if it's the final argument).
note that due to android lacking an implementation, the added functionality of this PR does not apply to Android. When source_location is implemented then this feature will automatically propogate to that platform as well.
This PR also updates the external deps litmus, fmt, and spdlog. All of which resolved issues exposed by the recent VC++ compiler.