Refactor ecs::details::component_info
#78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emory. Fixed defaults for `staged_sparse_memory_region_t` Temporarily added a conversion method to transform stages into the enum value
renamed `component_info` to `component_container_t` purged irrelevant implementations of `component_info`
This was referenced Dec 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements #64
component_infois nowcomponent_container_tcomponent_info_typedvariations now point to the specialized_untypedand_flagimplementations.staged_sparse_memory_region_tstaged_sparse_memory_region_tto remove performance discrepency withecs::details::staged_sparse_array_tit is meant to replace. As it is only used incomponent_info, and as it is a detail implementation of the ECS, it should not be leaking and causing binary bloat.It should now be possible for types that satisfy
component_type::TRIVIALandcomponent_type::FLAGto implement serialization safely.