Handle empty i_stream in chunked uploader start call.

Jesus · Nov 13, 2018 · e04aed9 · e04aed9
1 parent 42b597f
commit e04aed9
Show file tree

Hide file tree

Showing 3 changed files with 127 additions and 0 deletions.
diff --git a/lib/dropbox_api/chunked_uploader.rb b/lib/dropbox_api/chunked_uploader.rb
@@ -13,6 +13,7 @@ def initialize(client, path, i_stream, options = {})
 
     def start
       chunk = @i_stream.read @chunk_size
+      chunk = "" if chunk.nil?
 
       @cursor = @client.upload_session_start chunk
     end

diff --git a/spec/chunked_uploader_spec.rb b/spec/chunked_uploader_spec.rb
@@ -6,6 +6,20 @@ module DropboxApi
       @client = DropboxApi::Client.new
     end
 
+    it 'uploads a empty string', :cassette => "chunked_uploader/success_with_empty_string" do
+      content = StringIO.new("")
+
+      uploader = DropboxApi::ChunkedUploader.new(@client, "#{path_prefix}/new_file.txt", content, {
+        :chunk_size => 4
+      })
+      uploader.start
+      uploader.upload
+      file_data = uploader.finish
+
+      expect(file_data).to be_a(DropboxApi::Metadata::File)
+      expect(file_data.name).to eq('new_file.txt')
+    end
+
     it 'uploads a file', :cassette => "chunked_uploader/success" do
       content = File.open(File.join(DropboxScaffoldBuilder.fixtures_path, "file.txt"))
 

diff --git a/spec/fixtures/vcr_cassettes/chunked_uploader/success_with_empty_string.yml b/spec/fixtures/vcr_cassettes/chunked_uploader/success_with_empty_string.yml