Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refresh tokens support #81

Closed
massongit opened this issue May 29, 2021 · 6 comments
Closed

Refresh tokens support #81

massongit opened this issue May 29, 2021 · 6 comments

Comments

@massongit
Copy link
Contributor

https://dropbox.tech/developers/migrating-app-permissions-and-access-tokens

The dropbox api supports refresh tokens.
Therefore, I'd like you to support it in this library.
tomekdrazek added a commit to tomekdrazek/dropbox_api that referenced this issue Jul 13, 2021
@tomekdrazek
Implements Jesus#81 Refresh tokens support
72e785d
@tomekdrazek
Copy link
Contributor

Hi, I added the simplest I think implementation of the refresh tokens. I checked them out against new project with short lived tokens and seems to work fine. The only downside is you must create your own implementation of DropboxAPI::Token in order to provide token serialisation routines. The README.md has details how to make a new handshake to generate offline tokens with refresh ability. Any feedback welcome.

tomekdrazek added a commit to tomekdrazek/dropbox_api that referenced this issue Jul 14, 2021
@tomekdrazek
Jesus#81 Fixes issue with token not refreshing as auth_code was used …
5d26562 
…instead of OAuth2 client directly

The Authenticator now is directly driven from OAuth2::Client a thus requires change in the way how it is used (see samples from README.md)
@massongit
Copy link
Contributor Author

PR: #83

kostyanf14 added a commit to kostyanf14/dropbox_api that referenced this issue Sep 29, 2021
@tomekdrazek @kostyanf14
Add refresh tokens support
fa897cf 
Issue Jesus#81

Co-authored-by: Kostiantyn Kostiuk <konstantin@daynix.com>
kostyanf14 added a commit to kostyanf14/dropbox_api that referenced this issue Sep 29, 2021
@kostyanf14 @tomekdrazek
Update README.md
b3509b5 
Issue Jesus#81

Co-authored-by: Tomek <tomek.drazek@me.com>
Signed-off-by: Kostiantyn Kostiuk <konstantin@daynix.com>
kostyanf14 added a commit to kostyanf14/dropbox_api that referenced this issue Sep 29, 2021
@tomekdrazek @kostyanf14
Add refresh tokens support
c56ce2e 
Issue Jesus#81

Co-authored-by: Kostiantyn Kostiuk <konstantin@daynix.com>
kostyanf14 added a commit to kostyanf14/dropbox_api that referenced this issue Sep 29, 2021
@kostyanf14 @tomekdrazek
Update README.md
0172eca 
Issue Jesus#81

Co-authored-by: Tomek <tomek.drazek@me.com>
Signed-off-by: Kostiantyn Kostiuk <konstantin@daynix.com>
Jesus pushed a commit that referenced this issue Sep 29, 2021
@tomekdrazek @Jesus
Implements #81 Refresh tokens support
f5e2d50
Jesus pushed a commit that referenced this issue Sep 29, 2021
@tomekdrazek @Jesus
#81 Fixes issue with token not refreshing as auth_code was used inste…
434f30f 
…ad of OAuth2 client directly

The Authenticator now is directly driven from OAuth2::Client a thus requires change in the way how it is used (see samples from README.md)
@Jesus
Copy link
Owner

Jesus commented Sep 29, 2021

Done in #88

@Jesus Jesus closed this as completed Sep 29, 2021
@massongit
Copy link
Contributor Author

massongit commented Sep 30, 2021 •
edited

We take some time from the release of the new dropbox_api version to the the reflection on our system.
Therefore, if a similar situation occurs in the future, we want you to release the new version at least one month before the deadline.

@Jesus
Copy link
Owner

Jesus commented Oct 4, 2021

This is an open source project, if something like this occurs in the future you're welcome to contribute in advance.

@massongit
Copy link
Contributor Author

massongit commented Oct 4, 2021 •
edited

We can create a PR. In fact, in this case, tomekdrazek created #83 on July 13th, two months before the deadline.
However, only you can merge and release the PR, so we need your help so that we can handle it on a generous schedule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Jesus @tomekdrazek @massongit