JBR-7254 Impossible to copy/paste files in Project tree #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikitkoCent
requested changes
Jun 6, 2024
NikitkoCent
reviewed
Jun 7, 2024
Does it work for you under XToolkit when you copy a group of files from outside of IDEA, like from a file manager? It doesn't for me. When you copy within IDEA, it doesn't really go through the clipboard, there's a shortcut that can't be used with Wayland, in which case it will likely remain a limitation of WLToolkit for the foreseeable future. I will, nonetheless, look into this further. BTW, copying a group of files from IDEA to a file manager works both with WLToolkit and XToolkit. |
|
Copying of group of files has been fixed; the problem was the delimiter character: in encoding, |
It does (at least under XWayland): Ubuntu 22.04.4 + Gnome 42.9 under Wayland |
Pasting two empty files copied from one directory to another within the same empty project doesn't work on my side. However, I can paste those files through the Gnome file manager. Here're the logs (excluding pasting in the Gnome file manager): |
|
Pasting of multiple files copied from outside of the IDE works well though. As far as I understand from the logs, copying within IDE writes the files list to the clipboard as plain text instead of an uri list (or smth else?) |
Are you sure you have the latest commit? This scenario started working on my side with the recent changes. |
Ok, I confirm it works in PyCharm Nightly, but does not work in IDEA Nightly (e.g. today's build). Whenever I remove |
|
If the "Paste" dialog does not appear, you may be experiencing JBR-7290. Could you please re-try with a workaround for that issue ( |
|
@mkartashev, The difference I see here is that in IDEA case the clipboard is read only in 1 format (3 -> UTF8_STRING) several times, while in PyCharm case the clipboard is read in many different formats 1 time per format. IDK why this happens though. |
|
After some digging of the IntelliJ platform, I've got more details of how to reproduce the issue. And can't be reproduced if the files had been selected in the opposite order: Moreover now I think that the issue should be fixed on the IntelliJ side, not in JBR. Thus there's nothing more to do about the patch, so LGTM (and file a separate issue about the problem). |
NikitkoCent
approved these changes
Jun 18, 2024
|
A separate issue was filed to track the remaining problem: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JBR-7254 Impossible to copy/paste files in Project tree