Review fixes

CHANGELOG.md

@@ -6,6 +6,11 @@
 
 ### Features 🎉
 
+- New implementation of diagnostics extraction. It collects
+  both warnings and errors, doesn't show irrelevant errors
+  in BUILD files, shows line and character position and does
+  not run bazel query before each build anymore.
+  | [#225](https://github.com/JetBrains/bazel-bsp/pull/225)
 - `build_flags` support in project view.
   | [#194](https://github.com/JetBrains/bazel-bsp/pull/194)
 - New installer - it is possible to specify installation directory

server/src/main/java/org/jetbrains/bsp/bazel/server/diagnostics/BazelRootMessageParser.kt

@@ -1,7 +1,7 @@
 package org.jetbrains.bsp.bazel.server.diagnostics
 
 object BazelRootMessageParser : Parser {
-  private const val TargetLabel = """(//[\w/.-]+:[\w/.-]+)"""
+  private const val TargetLabel = """(//[\w/.-]*:[\w/.-]+)"""
 
   override fun tryParse(output: Output): List<Diagnostic> =
       findErrorInBUILD(output) ?: findWarningsInInfoMessage(output) ?: emptyList()
@@ -27,12 +27,8 @@ object BazelRootMessageParser : Parser {
     return output.tryTake(ErrorInBUILD)
         ?.let { match ->
           val targetLabel = match.groupValues[4].ifEmpty { null }
-          val compilerDiagnostics = collectCompilerDiagnostics(output, targetLabel)
-          if (compilerDiagnostics.isEmpty()) {
-            return listOf(createError(match, targetLabel))
-          } else {
-            return compilerDiagnostics
-          }
+          return collectCompilerDiagnostics(output, targetLabel)
+              .ifEmpty { listOf(createError(match, targetLabel)) }
         }
   }