add font rasterization settings in paragraph style #1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MatkovIvan please take a look |
MatkovIvan
requested changes
Feb 14, 2024
.../ui/ui-text/src/skikoMain/kotlin/androidx/compose/ui/text/FontRasterizationSettings.skiko.kt
Outdated
Show resolved
Hide resolved
.../ui/ui-text/src/skikoMain/kotlin/androidx/compose/ui/text/FontRasterizationSettings.skiko.kt
Outdated
Show resolved
Hide resolved
manu-unter
reviewed
Feb 15, 2024
.../ui/ui-text/src/skikoMain/kotlin/androidx/compose/ui/text/FontRasterizationSettings.skiko.kt
Outdated
Show resolved
Hide resolved
manu-unter
reviewed
Feb 15, 2024
.../ui/ui-text/src/skikoMain/kotlin/androidx/compose/ui/text/FontRasterizationSettings.skiko.kt
Outdated
Show resolved
Hide resolved
manu-unter
reviewed
Feb 15, 2024
compose/mpp/demo/src/commonMain/kotlin/androidx/compose/mpp/demo/FontRasterization.kt
Outdated
Show resolved
Hide resolved
manu-unter
reviewed
Feb 15, 2024
compose/mpp/demo/src/commonMain/kotlin/androidx/compose/mpp/demo/FontRasterization.kt
Outdated
Show resolved
Hide resolved
manu-unter
reviewed
Feb 15, 2024
compose/mpp/demo/src/commonMain/kotlin/androidx/compose/mpp/demo/FontRasterization.kt
Outdated
Show resolved
Hide resolved
manu-unter
reviewed
Feb 15, 2024
compose/mpp/demo/src/commonMain/kotlin/androidx/compose/mpp/demo/FontRasterization.kt
Outdated
Show resolved
Hide resolved
manu-unter
reviewed
Feb 15, 2024
.../ui/ui-text/src/skikoMain/kotlin/androidx/compose/ui/text/FontRasterizationSettings.skiko.kt
Outdated
Show resolved
Hide resolved
manu-unter
reviewed
Feb 15, 2024
.../ui/ui-text/src/skikoMain/kotlin/androidx/compose/ui/text/FontRasterizationSettings.skiko.kt
Outdated
Show resolved
Hide resolved
manu-unter
reviewed
Feb 15, 2024
...ose/ui/ui-text/src/skikoMain/kotlin/androidx/compose/ui/text/platform/SkiaParagraph.skiko.kt
Outdated
Show resolved
Hide resolved
manu-unter
reviewed
Feb 15, 2024
compose/mpp/demo/src/commonMain/kotlin/androidx/compose/mpp/demo/FontRasterization.kt
Outdated
Show resolved
Hide resolved
|
@manu-unter I took this names from Skia, but indeed |
SergeevPavel
force-pushed
the
font_rastr_settings
branch
2 times, most recently
from
15b3055
to
3c84e3f
Compare
MatkovIvan
reviewed
Feb 15, 2024
compose/ui/ui-text/src/skikoMain/kotlin/androidx/compose/ui/text/TextStyle.skiko.kt
Show resolved
Hide resolved
MatkovIvan
reviewed
Feb 15, 2024
.../ui/ui-text/src/skikoMain/kotlin/androidx/compose/ui/text/FontRasterizationSettings.skiko.kt
Outdated
Show resolved
Hide resolved
.../ui/ui-text/src/skikoMain/kotlin/androidx/compose/ui/text/FontRasterizationSettings.skiko.kt
Outdated
Show resolved
Hide resolved
Comment on lines
500
to
504
| val edging = when (rasterizationSettings.smoothing) { | ||
| FontSmoothing.None-> org.jetbrains.skia.FontEdging.ALIAS | ||
| FontSmoothing.AntiAlias -> org.jetbrains.skia.FontEdging.ANTI_ALIAS | ||
| FontSmoothing.SubpixelAntiAlias -> org.jetbrains.skia.FontEdging.SUBPIXEL_ANTI_ALIAS | ||
| } |
There was a problem hiding this comment.
- Apply auto formatting
- it's a good candidate for extraction to internal extension function for this enum (I'd put it in
FontRasterizationSettings.skiko.kt) file
igordmn
reviewed
Feb 20, 2024
.../ui/ui-text/src/skikoMain/kotlin/androidx/compose/ui/text/FontRasterizationSettings.skiko.kt
Outdated
Show resolved
Hide resolved
.../ui/ui-text/src/skikoMain/kotlin/androidx/compose/ui/text/FontRasterizationSettings.skiko.kt
Outdated
Show resolved
Hide resolved
compose/mpp/demo/src/commonMain/kotlin/androidx/compose/mpp/demo/FontRasterization.kt
Show resolved
Hide resolved
.../ui/ui-text/src/skikoMain/kotlin/androidx/compose/ui/text/FontRasterizationSettings.skiko.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Ivan Matkov <matkov.ivan@gmail.com>
SergeevPavel
force-pushed
the
font_rastr_settings
branch
from
40060f5
to
e9ae5d3
Compare
MatkovIvan
requested changes
Feb 21, 2024
| @@ -320,8 +356,10 @@ public final class androidx/compose/ui/text/PlaceholderVerticalAlign$Companion { | |||
| public final class androidx/compose/ui/text/PlatformParagraphStyle { | |||
| public static final field $stable I | |||
| public static final field Companion Landroidx/compose/ui/text/PlatformParagraphStyle$Companion; | |||
| public fun <init> ()V | |||
There was a problem hiding this comment.
You removed constructor without arguments. It breaks binary compatibility
MatkovIvan
approved these changes
Feb 21, 2024
igordmn
approved these changes
Feb 21, 2024
|
@igordmn could you grant me write access to the repo? |
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Allow to configure font rasterization settings
Testing
Check
FontRasterizationtab in demo applicationIssues Fixed
Fixes: [Optional] The bug on https://issuetracker.google.com being fixed
Google CLA
You need to sign the Google Contributor’s License Agreement at https://cla.developers.google.com/.
This is needed since we synchronise most of the code with Google’s AOSP repository. Signing this agreement allows us to synchronise code from your Pull Requests as well.