CfW: fix browser key events consumption #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eymar
commented
Feb 20, 2024
compose/ui/ui/src/webCommonW3C/kotlin/androidx/compose/ui/window/ComposeWindow.js.kt
Outdated
Show resolved
Hide resolved
eymar
changed the title
Schahen
reviewed
Feb 22, 2024
Schahen
reviewed
Feb 22, 2024
Schahen
reviewed
Feb 22, 2024
Schahen
approved these changes
Feb 22, 2024
igordmn
pushed a commit
that referenced
this pull request
Mar 4, 2024
Introduce new method `override fun onKeyboardEventWithResult(event: SkikoKeyboardEvent): Boolean` to know whether Compose processed a key event or not. If Compose processed a key event, then we call preventDefault.
eymar
added
changelog1.6.1
eymar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
JetBrains/compose-multiplatform#4399
Solution:
Introduce new method
override fun onKeyboardEventWithResult(event: SkikoKeyboardEvent): Booleanto know whether Compose processed a key event or not.If Compose processed a key event, then we call preventDefault.