Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CfW: fix browser key events consumption #1124

Merged
merged 4 commits into from
Feb 22, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -53,16 +53,20 @@ internal class ComposeLayer(
// Should be set to an actual value by ComposeWindow implementation
private var density = Density(1f)

private inner class ComponentImpl : SkikoView {
private inner class ComponentImpl : SkikoViewExtension {
override val input = this@ComposeLayer.input

override fun onRender(canvas: Canvas, width: Int, height: Int, nanoTime: Long) {
scene.render(canvas.asComposeCanvas(), nanoTime)
}

override fun onKeyboardEvent(event: SkikoKeyboardEvent) {
if (isDisposed) return
scene.sendKeyEvent(KeyEvent(event))
onKeyboardEventWithResult(event)
}

override fun onKeyboardEventWithResult(event: SkikoKeyboardEvent): Boolean {
if (isDisposed) return false
return scene.sendKeyEvent(KeyEvent(event))
}

override fun onPointerEvent(event: SkikoPointerEvent) {
Expand Down Expand Up @@ -183,4 +187,8 @@ internal fun SkikoPointerEvent.getScrollDelta(): Offset {
}?.let {
Offset(it.deltaX.toFloat(), it.deltaY.toFloat())
} ?: Offset.Zero
}

internal interface SkikoViewExtension : SkikoView {
fun onKeyboardEventWithResult(event: SkikoKeyboardEvent): Boolean
}
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ import androidx.compose.ui.events.toSkikoScrollEvent
import androidx.compose.ui.input.pointer.BrowserCursor
import androidx.compose.ui.input.pointer.PointerIcon
import androidx.compose.ui.native.ComposeLayer
import androidx.compose.ui.native.SkikoViewExtension
import androidx.compose.ui.platform.JSTextInputService
import androidx.compose.ui.platform.PlatformContext
import androidx.compose.ui.platform.ViewConfiguration
Expand Down Expand Up @@ -95,9 +96,9 @@ private class ComposeWindow(

val canvas = document.getElementById(canvasId) as HTMLCanvasElement

private fun <T : Event> HTMLCanvasElement.addTypedEvent(type: String, handler: (event: T, skikoView: SkikoView) -> Unit) {
private fun <T : Event> HTMLCanvasElement.addTypedEvent(type: String, handler: (event: T, skikoView: SkikoViewExtension) -> Unit) {
addEventListener(type, { event ->
layer.layer?.skikoView?.let { skikoView -> handler(event as T, skikoView) }
layer.layer?.skikoView?.let { skikoView -> handler(event as T, skikoView as SkikoViewExtension) }
eymar marked this conversation as resolved.
Show resolved Hide resolved
})
}

Expand Down Expand Up @@ -159,13 +160,13 @@ private class ComposeWindow(
})

canvas.addTypedEvent<KeyboardEvent>("keydown") { event, skikoView ->
event.preventDefault()
skikoView.onKeyboardEvent(event.toSkikoEvent(SkikoKeyboardEventKind.DOWN))
val processed = skikoView.onKeyboardEventWithResult(event.toSkikoEvent(SkikoKeyboardEventKind.DOWN))
if (processed) event.preventDefault()
}

canvas.addTypedEvent<KeyboardEvent>("keyup") { event, skikoView ->
event.preventDefault()
skikoView.onKeyboardEvent(event.toSkikoEvent(SkikoKeyboardEventKind.UP))
val processed = skikoView.onKeyboardEventWithResult(event.toSkikoEvent(SkikoKeyboardEventKind.UP))
if (processed) event.preventDefault()
}
}

Expand Down