[wasm][js] Correct density rounding in ComposeWindow::resize #1268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatkovIvan
reviewed
Apr 12, 2024
compose/ui/ui/src/webCommonW3C/kotlin/androidx/compose/ui/window/ComposeWindow.web.kt
Outdated
Show resolved
Hide resolved
|
|
||
| val width = boxSize.width * scaledDensity | ||
| val height = boxSize.height * scaledDensity | ||
| val width = (boxSize.width * scaledDensity).toInt() |
compose/ui/ui/src/webCommonW3C/kotlin/androidx/compose/ui/window/ComposeWindow.web.kt
Outdated
Show resolved
Hide resolved
eymar
approved these changes
Apr 12, 2024
…ow/ComposeWindow.web.kt Co-authored-by: Ivan Matkov <ivan.matkov@jetbrains.com>
MatkovIvan
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problems happen when the scaling is not an integer (say, 125%, 150% etc.) - we need to round only after we've resolved dimensions.
This supposedly fix issues we've encountered on Windows platform (see COMPOSE-1170 and in certain android phones)