Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm][js] Correct density rounding in ComposeWindow::resize #1268

Merged
merged 4 commits into from
Apr 12, 2024
Merged

[wasm][js] Correct density rounding in ComposeWindow::resize #1268

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
85fc3aa
[wasm][js] Correct density rounding in ComposeWindow::resize
Schahen Apr 12, 2024
101c389
Update compose/ui/ui/src/webCommonW3C/kotlin/androidx/compose/ui/wind…
Schahen Apr 12, 2024
41de92e
Fix after incomplete changes application
Schahen Apr 12, 2024
15604bb
Remove redundant comment
Schahen Apr 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions compose/ui/ui/src/webCommonW3C/kotlin/androidx/compose/ui/window/ComposeWindow.web.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,11 +305,10 @@ internal class ComposeWindow(
}

fun resize(boxSize: IntSize) {
// FIXME: density is not integer
val scaledDensity = density.density.toInt()
val scale = density.density

val width = boxSize.width * scaledDensity
val height = boxSize.height * scaledDensity
val width = (boxSize.width * scale).toInt()
val height = (boxSize.height * scale).toInt()

canvas.width = width
canvas.height = height
Expand Down
Loading