Invalidate parent layer every time child layer is invalidated #1316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes JetBrains/compose-multiplatform#4681 The issue was because of this situation: - the parent RenderNodeLayer is drawn and cached it's `picture` - the child RenderNodeLayer isn't drawn, but `invalidate` is called the child's `invalidate` should invalidate parent layer unconditionally, but we called it only if the child was drawn (picture != null), which is incorrect. It is a regression after #1260, but it just revealed the bug, not introduced it. ## Testing - new added tests fail before, work after the fix - the issue is no longer reproducible This should be tested by QA ## Release Notes > Fixes - Multiple Platforms - _(prerelease fix)_ Fix frozen composition with pager and text field
MatkovIvan
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes JetBrains/compose-multiplatform#4681
The issue was because of this situation:
pictureinvalidateis calledinvalidateshould have updated the parent layer (removing thepicturecache), but didn't do that as we do that conditionally. Nowinvalidateinvalidates the parent layer unconditionally.It is a regression after #1260, but it just revealed the bug, didn't introduce it.
Testing
This should be tested by QA
Release Notes