Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalidate parent layer every time child layer is invalidated #1316

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Invalidate parent layer every time child layer is invalidated #1316

merged 1 commit into from
Apr 25, 2024

Commits on Apr 24, 2024

  1. Invalidate parent layer every time child layer is invalidated 

    Fixes JetBrains/compose-multiplatform#4681

The issue was because of this situation:
- the parent RenderNodeLayer is drawn and cached it's `picture`
- the child RenderNodeLayer isn't drawn, but `invalidate` is called

the child's `invalidate` should invalidate parent layer unconditionally, but we called it only if the child was drawn (picture != null), which is incorrect.

It is a regression after #1260, but it just revealed the bug, not introduced it.

## Testing
- new added tests fail before, work after the fix
- the issue is no longer reproducible

This should be tested by QA

## Release Notes
> Fixes - Multiple Platforms
- _(prerelease fix)_ Fix frozen composition with pager and text field
    @igordmn
    igordmn committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    1f0ec3d View commit details
    Browse the repository at this point in the history