Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

External drag and drop support for compose application #391

Merged
merged 31 commits into from
Mar 13, 2023
Merged

External drag and drop support for compose application #391

merged 31 commits into from
Mar 13, 2023

Commits on Mar 2, 2023

  1. Introduce external file drag and drop support for desktop

    @Walingar
    Walingar committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    d0de9fd View commit details
    Browse the repository at this point in the history

  2. Introduce more drop data types for external drag support

    @Walingar
    Walingar committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    c67d3e2 View commit details
    Browse the repository at this point in the history

  3. Add docs to external drag API

    @Walingar
    Walingar committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    2cf9055 View commit details
    Browse the repository at this point in the history

  4. Add offset to dragStart callback like in onDrag function

    @Walingar
    Walingar committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    e07fa23 View commit details
    Browse the repository at this point in the history

  5. Move awt point -> offset logic closer to drag event

    @Walingar
    Walingar committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    b62ff6f View commit details
    Browse the repository at this point in the history

  6. Introduce tests for external drag support

    @Walingar
    Walingar committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    decc04a View commit details
    Browse the repository at this point in the history

  7. Mark external drop API as experimental

    @Walingar
    Walingar committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    6614da1 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2023

  1. Use handlers.values

    @Walingar
    Walingar committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    bae882e View commit details
    Browse the repository at this point in the history

  2. Use componentBounds instead of LayoutCoordinates for external drag su… 

    …pport
    @Walingar
    Walingar committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    c4945f4 View commit details
    Browse the repository at this point in the history

  3. Wrap lambdas in rememberUpdatedState

    @Walingar
    Walingar committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    bec5531 View commit details
    Browse the repository at this point in the history

  4. Add experimental compose api opt in

    @Walingar
    Walingar committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    b6150fe View commit details
    Browse the repository at this point in the history

  5. Introduce test to check that drag enter/cancel are not spammed on com… 

    …ponent bounds change
    @Walingar
    Walingar committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    79dc947 View commit details
    Browse the repository at this point in the history

  6. Don't reinstall component drag handlers on recomposition, just provid… 

    …e new component bounds to Swing
    @Walingar
    Walingar committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    27b7493 View commit details
    Browse the repository at this point in the history

  7. Extract common code for drag event handling

    @Walingar
    Walingar committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    fe62f4f View commit details
    Browse the repository at this point in the history

  8. Update idsCounter immediately and use current handleId

    @Walingar
    Walingar committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    850ba62 View commit details
    Browse the repository at this point in the history

  9. Change doc

    @Walingar
    Walingar committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    b802866 View commit details
    Browse the repository at this point in the history

  10. Update tests: don't notify onDrag if onDragEntered notified

    @Walingar
    Walingar committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    33470de View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2023

  1. Remove VisibleForTesting, can be added in the future if needed

    @Walingar
    Walingar committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    c2f82de View commit details
    Browse the repository at this point in the history

  2. Move external drag support to androidx.compose.ui package

    @Walingar
    Walingar committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    d068e92 View commit details
    Browse the repository at this point in the history

  3. Rename forAll -> forEach

    @Walingar
    Walingar committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    56f0cff View commit details
    Browse the repository at this point in the history

  4. Merge value acquiring and remove

    @Walingar
    Walingar committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    095c3a2 View commit details
    Browse the repository at this point in the history

  5. Take changed callbacks into account in AwtWindowDropTarget

    @Walingar
    Walingar committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    21943c6 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2023

  1. Modify DropData API 

    * don't use sealed interface and data classes
* provide mimeTypes for all drop data
* provide methods to read drop data content instead of having properties
    @Walingar
    Walingar committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    80eee0d View commit details
    Browse the repository at this point in the history

  2. Always provide offset and drop data to external drag feature

    @Walingar
    Walingar committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    c0b992c View commit details
    Browse the repository at this point in the history

  3. Rename onDragCancel -> onDragExit

    @Walingar
    Walingar committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    5f650fb View commit details
    Browse the repository at this point in the history

  4. Rename DropData -> DragData and update javadocs

    @Walingar
    Walingar committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    60e7b65 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2023

  1. Don't provide mimeTypes, it is not needed

    @Walingar
    Walingar committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    6a9c42b View commit details
    Browse the repository at this point in the history

  2. Rename State -> Value

    @Walingar
    Walingar committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    5b2dac4 View commit details
    Browse the repository at this point in the history

  3. Convert interface to class for current drag state

    @Walingar
    Walingar committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    2c31a2e View commit details
    Browse the repository at this point in the history

  4. Add immutable annotation

    @Walingar
    Walingar committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    b44a3b1 View commit details
    Browse the repository at this point in the history

  5. Update compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/Exter… 

    …nalDrag.desktop.kt

Co-authored-by: Igor Demin <igordmn@users.noreply.github.com>
    @Walingar @igordmn
    Walingar and igordmn committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    62cec60 View commit details
    Browse the repository at this point in the history