Expect androidx.compose.material.DropdownMenu in common
#738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatkovIvan
commented
Aug 8, 2023
compose/material/material/src/commonMain/kotlin/androidx/compose/material/Menu.kt
Outdated
Show resolved
Hide resolved
compose/material/material/src/commonMain/kotlin/androidx/compose/material/Menu.kt
Outdated
Show resolved
Hide resolved
MatkovIvan
force-pushed
the
ivan.matkov/common-alertdialog
branch
from
3b1e95e
to
87da601
Compare
MatkovIvan
force-pushed
the
ivan.matkov/common-dropdownmenu
branch
from
787a813
to
4164545
Compare
MatkovIvan
commented
Aug 9, 2023
| @@ -160,31 +164,22 @@ class DesktopMenuTest { | |||
| // (RTL) Anchor right is beyond the right of the window, so align popup to the window right | |||
| @Test | |||
| fun menu_positioning_rtl_windowRight_belowAnchor() { | |||
igordmn
reviewed
Aug 9, 2023
...se/material/material/src/desktopMain/kotlin/androidx/compose/material/DesktopMenu.desktop.kt
Show resolved
Hide resolved
igordmn
approved these changes
Aug 10, 2023
MatkovIvan
force-pushed
the
ivan.matkov/common-dropdownmenu
branch
from
3b2b4fb
to
3d54d92
Compare
igordmn
pushed a commit
that referenced
this pull request
Nov 15, 2023
…Menu` in common (#738) * Expect DropdownMenu in common * Deprecate old DropdownMenu overloads * Fix class name in tests * Fix binary compatibility for DropdownMenuItem * Move missing Rtl fix to common * Revert DropdownMenuPositionProvider fixes * Update Rtl test * Fix DesktopMenuTest tests
igordmn
pushed a commit
that referenced
this pull request
Nov 16, 2023
…DropdownMenu` in common (#738) * Expect DropdownMenu in common * Deprecate old DropdownMenu overloads * Fix class name in tests * Fix binary compatibility for DropdownMenuItem * Move missing Rtl fix to common * Revert DropdownMenuPositionProvider fixes * Update Rtl test * Fix DesktopMenuTest tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
DropdownMenuandDropdownMenuItemin commonDesktopDropdownMenuPositionProviderto common (requires upstreaming)Testing
Test: try to use
DropdownMenuandDropdownMenuItemTODO: add to
mppdemo