Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PopupProperties.clippingEnabled setting #740

Merged
merged 7 commits into from Aug 9, 2023
Merged

Add PopupProperties.clippingEnabled setting #740

merged 7 commits into from Aug 9, 2023

Conversation

MatkovIvan
Copy link
Member

@MatkovIvan MatkovIvan commented Aug 9, 2023 •
edited

Proposed Changes

  • Add PopupProperties.clippingEnabled setting
  • Fix flickering because of unavailable parentBounds on first frame

Testing

Test: run PopupTest

@MatkovIvan MatkovIvan mentioned this pull request Aug 9, 2023
Merged
@MatkovIvan MatkovIvan marked this pull request as ready for review August 9, 2023 11:37
@MatkovIvan MatkovIvan merged commit d775feb into jb-main Aug 9, 2023
3 checks passed
@MatkovIvan MatkovIvan deleted the ivan.matkov/popup-clipping branch August 9, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igordmn igordmn igordmn approved these changes

@m-sasha m-sasha Awaiting requested review from m-sasha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@MatkovIvan @igordmn