iOS postpone CAMetalDrawable acqusition #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elijah-semyonov
changed the title
MatkovIvan
reviewed
Sep 18, 2023
| * Flush async operations, notify all animations and perform recomposition-layout-draw sequence. | ||
| * [Canvas] to draw on is retrieved lazily to postpone acquiring drawable as late as possible. | ||
| */ | ||
| fun render(retrieveCanvas: () -> Canvas?, nanoTime: Long): Unit = postponeInvalidation { |
There was a problem hiding this comment.
It's a new public API.
- Should we make it experimental at first?
- Should we deprecate old one?
There was a problem hiding this comment.
Alternative solutions:
- separate to
doFrameanddraw - make custom LazyCanvas implementation
There was a problem hiding this comment.
I marked it internal for now. Public API doesn't change.
The old one should probably be deprecated. It's correct, but most likely unoptimal in terms of swap chain usage. Needs investigation on DirectX and OpenGL to prove or disprove it. Added TODO.
MatkovIvan
reviewed
Sep 19, 2023
compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/window/MetalRedrawer.kt
Show resolved
Hide resolved
igordmn
approved these changes
Sep 19, 2023
elijah-semyonov
added a commit
that referenced
this pull request
Sep 21, 2023
## Proposed Changes Adhere to [Apple best practices](https://developer.apple.com/library/archive/documentation/3DDrawing/Conceptual/MTLBestPracticesGuide/Drawables.html) > Always acquire a drawable as late as possible; preferably, immediately before encoding an on-screen render pass. A frame’s CPU work may include dynamic data updates and off-screen render passes that you can perform before acquiring a drawable. and postpone drawable acqusition till the actual rendering work starts. ## Testing Test: N/A ## Issues Fixed Fixes: drawable being acquired before rendering is performed causing occasional stalls. before | after --- | --- <img width="620" alt="Screenshot 2023-09-15 at 14 51 23" src="https://github.com/JetBrains/compose-multiplatform-core/assets/4167681/d6051c73-833a-45ec-bb5c-7fcc3418bcf9"> | <img width="485" alt="Screenshot 2023-09-18 at 12 19 15" src="https://github.com/JetBrains/compose-multiplatform-core/assets/4167681/5098a952-a2ac-4e66-be41-6d5d3ffac894">
elijah-semyonov
added a commit
that referenced
this pull request
Sep 26, 2023
## Proposed Changes If no CATransaction sync is needed, perform Picture recorded commands execution on a separate thread. Fix a freeze on `waitUntilScheduled` if no transaction is available by moving synchronization from interop scope (any UIView is present in the composition) to per-frame scope (any UIView transaction is issued by composition in current frame). ## Testing Test: N/A ## Issues Fixed Removes work from main thread, when possible, allowing Compose to run there without waiting for CPU to finish encoding GPU commands. A freeze on `waitUntilScheduled` during interop synchronization if no transaction is available. <img width="324" alt="Screenshot 2023-09-19 at 12 13 00" src="https://github.com/JetBrains/compose-multiplatform-core/assets/4167681/e54d83e3-ca58-43aa-a4a7-4764dd8ce841"> <img width="371" alt="Screenshot 2023-09-19 at 12 13 05" src="https://github.com/JetBrains/compose-multiplatform-core/assets/4167681/8e4fcf0b-2b64-473e-a930-fae97a086a12"> ## Depends on #820
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Adhere to Apple best practices
and postpone drawable acqusition till the actual rendering work starts.
Testing
Test: N/A
Issues Fixed
Fixes: drawable being acquired before rendering is performed causing occasional stalls.