forked from androidx/androidx
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move frame encoding to separate thread when possible #829
Merged
elijah-semyonov
merged 18 commits into
jb-main
from
es/move-frame-encoding-to-separate-thread
Sep 26, 2023
Merged
Move frame encoding to separate thread when possible #829
elijah-semyonov
merged 18 commits into
jb-main
from
es/move-frame-encoding-to-separate-thread
Sep 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elijah-semyonov
force-pushed
the
es/move-frame-encoding-to-separate-thread
branch
from
September 21, 2023 11:24
2aecc55
to
92b9bd3
Compare
igordmn
reviewed
Sep 21, 2023
compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/window/MetalRedrawer.kt
Outdated
Show resolved
Hide resolved
compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/window/MetalRedrawer.kt
Show resolved
Hide resolved
Back to draft due to:
and freeze on VisualEffects after firework ends. |
igordmn
approved these changes
Sep 25, 2023
elijah-semyonov
deleted the
es/move-frame-encoding-to-separate-thread
branch
September 26, 2023 07:36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
If no CATransaction sync is needed, perform Picture recorded commands execution on a separate thread.
Fix a freeze on
waitUntilScheduled
if no transaction is available by moving synchronization from interop scope (any UIView is present in the composition) to per-frame scope (any UIView transaction is issued by composition in current frame).Testing
Test: N/A
Issues Fixed
Removes work from main thread, when possible, allowing Compose to run there without waiting for CPU to finish encoding GPU commands.
A freeze on
waitUntilScheduled
during interop synchronization if no transaction is available.Depends on
#820