Skip to content

Commit

Permalink
Support kotlin 1.8.20 in compose.html lib (#3029)
Browse files Browse the repository at this point in the history
Fix: take `kotlin-test-js-runner` from node_modules
Move previously failing compose-compiler test cases to passing folder.
  • Loading branch information
eymar committed Apr 11, 2023
1 parent dd5252d commit 129c78d
Show file tree
Hide file tree
Showing 7 changed files with 276 additions and 29 deletions.
2 changes: 1 addition & 1 deletion html/buildSrc/gradle.properties
Original file line number Diff line number Diff line change
@@ -1 +1 @@
kotlin.version=1.8.10
kotlin.version=1.8.20
2 changes: 1 addition & 1 deletion html/buildSrc/src/main/kotlin/SeleniumDriverPlugin.kt
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import org.gradle.nativeplatform.platform.internal.DefaultNativePlatform
import java.io.File
import java.net.URL

private val CHROME_DRIVER_VERSION = "108.0.5359.71"
private val CHROME_DRIVER_VERSION = "112.0.5615.49"
private val GECKO_DRIVER_VERSION = "0.31.0"

private fun download(url: String, file: File) {
Expand Down
4 changes: 2 additions & 2 deletions html/gradle.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
compose.version=1.3.1
compose.version=1.4.0-rc03
compose.web.buildSamples=false
compose.web.tests.integration.withFirefox
compose.web.tests.skip.benchmarks=false
org.gradle.jvmargs=-Xmx8g
org.gradle.jvmargs=-Xmx8g
293 changes: 270 additions & 23 deletions html/kotlin-js-store/yarn.lock

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ const NewReporter = function(baseReporterDecorator, config, emitter) {

const path = require('path');
const fs = require('fs');
const kotlinVersion = fs.readFileSync(path.resolve(__dirname, "../../../buildSrc/build/kotlin.version"), 'utf8');
// const kotlinVersion = fs.readFileSync(path.resolve(__dirname, "../../../buildSrc/build/kotlin.version"), 'utf8');

const kotlinReporterModule = require(`../../../build/js/packages_imported/kotlin-test-js-runner/${kotlinVersion}/karma-kotlin-reporter`);
const kotlinReporterModule = require(`../../../build/js/node_modules/kotlin-test-js-runner/karma-kotlin-reporter`);
const KotlinReporter = kotlinReporterModule['reporter:karma-kotlin-reporter'][1];
this.$inject = KotlinReporter.$inject

Expand Down

0 comments on commit 129c78d

Please sign in to comment.