Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make compose.html support kotlin 1.8.20 #3029

Merged
merged 2 commits into from
Apr 11, 2023

Conversation

eymar
Copy link
Collaborator

@eymar eymar commented Apr 11, 2023

We had an issue with kotlin-test-js-runner, its version was 0.0.1 in kotlin 1.8.20
Now we take kotlin-test-js-runner from /build/js/node_modules/kotlin-test-js-runner symlink.

Fix: take `kotlin-test-js-runner` from node_modules
Move previously failing compose-compiler test cases to passing folder.
@eymar eymar requested a review from igordmn April 11, 2023 09:51
@eymar eymar marked this pull request as draft April 11, 2023 09:52
@eymar eymar marked this pull request as ready for review April 11, 2023 09:56
@eymar eymar merged commit 129c78d into support/1.4.0 Apr 11, 2023
@eymar eymar deleted the compose-html-support-kotlin-1820 branch April 11, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants