Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR fixes two issues with the
VideoPlayer
sample.🐛 No Video
Problem:
vlcj
'sEmbeddedMediaPlayerComponent
to play the video. This component doesn't work on macOS due to insufficient support from theAWT
side. [1][2]. This caused the player not to play the video on macOS.Solution:
EmbeddedMediaPlayerComponent
orCallbackMediaPlayerComponent
(for macOS) accordingly. (here's the commit 1e396c7)🐛 Local file path Issue
Problem:
Previously, the URL was a local file path that wouldn't exist in every system.
Solution:
Update it to a public URL. Here's the commit (4366a6e)
Output
player.mp4