Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VideoPlayer #1088

Merged
merged 2 commits into from
Aug 21, 2021
Merged

Fix VideoPlayer #1088

merged 2 commits into from
Aug 21, 2021

Conversation

theapache64
Copy link
Contributor

@theapache64 theapache64 commented Aug 21, 2021

Changes

This PR fixes two issues with the VideoPlayer sample.

🐛 No Video

Problem:

  • Previously, we were using vlcj's EmbeddedMediaPlayerComponent to play the video. This component doesn't work on macOS due to insufficient support from the AWT side. [1][2]. This caused the player not to play the video on macOS.

Solution:

  • Check the OS type and provide EmbeddedMediaPlayerComponent or CallbackMediaPlayerComponent(for macOS) accordingly. (here's the commit 1e396c7)

🐛 Local file path Issue

Problem:
Previously, the URL was a local file path that wouldn't exist in every system.

Solution:
Update it to a public URL. Here's the commit (4366a6e)

Output

player.mp4

@igordmn
Copy link
Collaborator

igordmn commented Aug 21, 2021

Found issues:

  1. Fullscreen is too slow on macOs on my machine (MacBook Pro 2019 16" i9), but not slow on the theapache64 machine.
  2. I noticed a frame tearing (as happened when vsync is disabled)
  3. Encountered:
 java.io.IOException: Native library (darwin/libvlc.dylib) not found in resource path

until I installed VLC:

brew install vlc

I think we need to bundle VLC as a part of VideoPlayer.

@igordmn igordmn merged commit 01355cc into JetBrains:master Aug 21, 2021
@theapache64 theapache64 deleted the fix/player branch August 21, 2021 10:05
@theapache64
Copy link
Contributor Author

theapache64 commented Aug 21, 2021

Fullscreen is too slow on macOs on my machine (MacBook Pro 2019 16" i9), but not slow on the theapache64 machine.

@igordmn I am using the same MBP, but with a dual monitor setup. I was running the demo on the external monitor. Moving the output window to MBC's display also causing the same issue.

mareklangiewicz pushed a commit to mareklangiewicz/compose-jb that referenced this pull request Feb 14, 2022
* fix player's macOS issue

* replace local file path with public URL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants