Rename Web to HTML #2997
Merged
Rename Web to HTML #2997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Rename "compose.web" to "compose.html" in Gradle DSL 2. Rename maven artifacts (with backward compatible "relocation" artifact) 3. Rename "web" folder to "html" Will do in support/1.4.0 branch 1. Move examples/web-* to examples/html/* 2. Rename Tutorials/Web to Tutorials/HTML 3. Rename "Compose for Web" to "Compose HTML Library" in the tutorials
igordmn
commented
Apr 6, 2023
| if "%OS%"=="Windows_NT" endlocal | ||
|
|
||
| :omega | ||
| @rem |
There was a problem hiding this comment.
It seems it was converted to Unix-Style line endings on committing. Bat files works normally on Windows with these line endings.
eymar
reviewed
Apr 6, 2023
|
In our CI configuration [3. Components. Web. Test], it expects "web" directory. The configuration will need to be changed too. |
eymar
approved these changes
Apr 6, 2023
bitspittle
added a commit
to varabyte/kobweb
that referenced
this pull request
Apr 14, 2023
bitspittle
added a commit
to varabyte/kobweb
that referenced
this pull request
Apr 14, 2023
This is in response to an upstream rebranding by JetBrains See also: JetBrains/compose-multiplatform#2997 And also: https://www.reddit.com/r/Kotlin/comments/12kauzh/comment/jg1w080/
igordmn
added a commit
to JetBrains/compose-multiplatform-core
that referenced
this pull request
Jan 3, 2024
Fixes https://youtrack.jetbrains.com/issue/COMPOSE-711/Support-collectioncollection - ignore jvmMain/jvmTest implementation from AOSP - use atomicfu. it isn't stable, but we already use it in `runtime`. We will publish collections as org.jetbrains.compose.collection-internal:$composeVersion. If in the future we decide to change the group or decouple versioninig from Compose, we can use Maven group relocation (example JetBrains/compose-multiplatform#2997)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename "compose.web" to "compose.html" in Gradle DSL. Users will see this:
Rename maven artifacts (with backward compatible "relocation" artifact). In case users don't use Gradle DSL, or when they use a library that depend on the old Compose version.
Rename "web" folder to "html"
An example build: 0.0.0-igor.demin-rename-web-to-html-dev1014
Will do in support/1.4.0 branch: