Fix package name of generated Res file when project is building for JsTarget (#4295)
#4296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the contribution. You are supposed to provide tests cover the issue |
|
@terrakok Thanks for review. I have added a test case that verifies the issue is fixed. Let me know if it works or if I need to add some more test cases |
suhaibroomy
force-pushed
the
suhaib/fix-js-res-generation
branch
from
106f4c5
to
bdfed3d
Compare
|
Reworked tests: #4300 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix package name of generated
Resfile when project is building for JsTarget (#4295)