Fix package name of generated Res file when project is building for JsTarget (#4295) #4300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixes #4295 |
|
@terrakok Can we get this merged so that it makes into the final 1.6.0 release? |
pjBooms
approved these changes
Mar 4, 2024
terrakok
added
the
changelog1.6.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR fixes an error
Name contains illegal charactersin generatedRes.ktwhile buildingjsTargetwhen the project name contains hyphen. This happens since the Plugin gets the project name and appends it to the generated files package name within ``. This works fine on androidTargets but generates an error with JsTargetOrigin: #4296