Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smart processing of 'headerParserRegex' property #12

Merged
merged 3 commits into from
Oct 13, 2020
Merged

Conversation

AlexPl292
Copy link
Member

Hi! In continuation of #11

In my opinion new Regex doesn't look really "declarative" for Gradle configuration. I suggest to add smart processing of 'headerParserRegex' property: if this property is a regex - leave it as it is. If it's a string - convert it to the regex.

Unfortunately, I wasn't able to find a test that uses headerParserRegexProperty directly.

@hsz
Copy link
Member

hsz commented Oct 13, 2020

Thanks, I like that approach!
I had to adjust your implementation because headerParserRegexProperty is not available via Gradle configuration, but headerParserRegex.

@hsz hsz merged commit e747d15 into JetBrains:main Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants