Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IDEA-290250] Improve the order of the editor popup menu entries #1592

Closed
wants to merge 1 commit into from
Closed

[IDEA-290250] Improve the order of the editor popup menu entries #1592

wants to merge 1 commit into from

Conversation

Fabrice-TIERCELIN
Copy link
Contributor

Hi,

Among other entries, we have:

Find Usages
Refactor

Folding
Analyze

Go to
Generate...

Find Usages and Go to are both navigation features. Refactor and Generate... are both automatic code writing features. They should be gathered. I suggest to switch Refactor and Go to.

@yole, I have successfully tested.

@Fabrice-TIERCELIN Fabrice-TIERCELIN changed the title Improve the order of the editor popup menu entries [IDEA-290250] Improve the order of the editor popup menu entries Mar 9, 2022
@Fabrice-TIERCELIN
Copy link
Contributor Author

@ybedrov, perhaps it should be reassigned. The PR hasn't changed for 10 months.

@akozlova
Copy link
Contributor

The change looks logical but there are 2 considerations:

  1. muscle memory
  2. probably Go To actions are used by shortcuts more than refactorings, so the change would result in more "scrolling" for them.
    What do you think, does it really worth it? Thanks

@Fabrice-TIERCELIN
Copy link
Contributor Author

I can invert the order if you want:

Generate...
Refactor

Folding
Analyze

Find Usages
Go to

Muscle memory is important, but it's better to consider the future than the past.

@akozlova
Copy link
Contributor

Doesn't solve the second issue, that goto is most probably invoked with the mouse or shortcut.

@Fabrice-TIERCELIN
Copy link
Contributor Author

So let's keep Go to... at the same place and move the others. There are a number of possibilities!

@Fabrice-TIERCELIN
Copy link
Contributor Author

@akozlova, to move the debate forward, I suggest to move only one entry, let's say Go to:

Find Usages
Go to
Refactor

Folding
Analyze

Generate...

@akozlova
Copy link
Contributor

akozlova commented Aug 1, 2022

@yole I think, I am fine with the suggested change, you?

@Fabrice-TIERCELIN Fabrice-TIERCELIN force-pushed the better_menu_order branch 2 times, most recently from 3245cb1 to ed12b65 Compare August 2, 2022 05:18
@yole
Copy link
Contributor

yole commented Dec 29, 2022

Thanks for your contribution! We implemented part of these changes internally; I hope the result works well for you.

@yole yole closed this Dec 29, 2022
@Fabrice-TIERCELIN
Copy link
Contributor Author

I had the opportunity to test it successfully on IntelliJ 2021.1.3

I can't test on a more recent installation because we can't hack the files of the installation on the further versions.

@Fabrice-TIERCELIN
Copy link
Contributor Author

I have successfully verified this feature with this configuration:
IntelliJ IDEA 2023.1 EAP (Community Edition)
Build #IC-231.4840.387, built on January 19, 2023
Runtime version: 17.0.5+8-b759.1 amd64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
Windows 10 10.0
GC: G1 Young Generation, G1 Old Generation
Memory: 1010M
Cores: 4
Non-Bundled Plugins:
com.dubreuia (2.3.0)

Kotlin: 231-1.7.21-release-272-IJ4840.387

@Fabrice-TIERCELIN Fabrice-TIERCELIN deleted the better_menu_order branch January 24, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@yole yole

@akozlova akozlova

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Fabrice-TIERCELIN @akozlova @yole