IDEA-348914 JBSlidingPanel: unused variable and raw use of parametrized class #2707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt to Kotlin for Enhanced Type Safety and Generics 1. In JBSlidingPanel, unused variable `mySelectedIndex` removed (it was initialized and conditionally updated by never read.) 2. Add method removed since it only updated unused variable 3. In JBSlidingPanel, JBPanel class is properly parametrized, no more warnings 4. JBPanel and JBComponent converted to Kotlin. Thanks to Kotlin's recursive generics support, the need for raw use of parametrized type JBPanel eliminated. 5. Change 4 permitted eliminate constructions like `JBPanel<JBPanel<*>?>()` in many instances across the project 6. In AbstractDroppableStripe, getPreferredSize is refactored to comply with JPanel interface that does not permit null value (actually it's already accessed in many places in the project without considering potential null value which permits to infer non-null contract; due to conversion to Kotlin it's strictly verified)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(IDEA-348914) Refactor JBSlidingPanel and Convert JBPanel & JBComponent to Kotlin for Enhanced Type Safety and Generics
mySelectedIndexremoved (it was initialized and conditionally updated by never read.)JBPanel<JBPanel<*>?>()in many instances across the projectAbstractDroppableStripe,getPreferredSizeis refactored to comply withJPanelinterface that does not permit null value (actually it's already accessed in many places in the project without considering potential null value which permits to infer non-null contract; due to conversion to Kotlin it's strictly verified)