Improve Debugger Tests ART Integration #2766
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zuevmaxim
reviewed
May 22, 2024
| } | ||
| } | ||
|
|
||
| private fun loadProvider(className: String, testCase: KotlinDescriptorTestCase): RemoteConnectionProvider { |
There was a problem hiding this comment.
Could you please elaborate a bit on why such flexibility is needed?
There was a problem hiding this comment.
We are working on a way to run these tests from our own repository.
As we fix bugs, we expect to have to change the way the ART VM is launched. For example, we may want to add a certain command line option to the VM in order to activate some experimental feature/fix.
Since we can't anticipate what changes we will need, we would like to be able to have our own version of the ArtAttacher so we can iterate faster. When we stabilize it, we will merge it back upstream.
...vm-debugger/test/test/org/jetbrains/kotlin/idea/debugger/test/ArtRemoteConnectionProvider.kt
Outdated
Show resolved
Hide resolved
...n/jvm-debugger/test/test/org/jetbrains/kotlin/idea/debugger/test/KotlinDescriptorTestCase.kt
Outdated
Show resolved
Hide resolved
...n/jvm-debugger/test/test/org/jetbrains/kotlin/idea/debugger/test/KotlinDescriptorTestCase.kt
Outdated
Show resolved
Hide resolved
...n/jvm-debugger/test/test/org/jetbrains/kotlin/idea/debugger/test/KotlinDescriptorTestCase.kt
Outdated
Show resolved
Hide resolved
...n/jvm-debugger/test/test/org/jetbrains/kotlin/idea/debugger/test/KotlinDescriptorTestCase.kt
Outdated
Show resolved
Hide resolved
...n/jvm-debugger/test/test/org/jetbrains/kotlin/idea/debugger/test/RemoteConnectionProvider.kt
Outdated
Show resolved
Hide resolved
...n/jvm-debugger/test/test/org/jetbrains/kotlin/idea/debugger/test/RemoteConnectionProvider.kt
Outdated
Show resolved
Hide resolved
alonalbert
force-pushed
the
IJPL-150161
branch
2 times, most recently
from
0ac9e95
to
27cd144
Compare
zuevmaxim
reviewed
May 27, 2024
plugins/kotlin/jvm-debugger/test/test/org/jetbrains/kotlin/idea/debugger/test/VmAttacher.kt
Outdated
Show resolved
Hide resolved
plugins/kotlin/jvm-debugger/test/test/org/jetbrains/kotlin/idea/debugger/test/VmAttacher.kt
Show resolved
Hide resolved
Extract an interface that will allow Android Studio to inject a class that will handle ART VM debugger dependencies. The interface is agnostic to ART. It should work for any remote VM.
zuevmaxim
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract an interface that will allow Android Studio to inject a class that will handle ART VM debugger dependencies.
The interface is agnostic to ART. It should work for any remote VM.