Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fish now will respect user's selected prompt #749

Closed
wants to merge 3 commits into from
Closed

Fish now will respect user's selected prompt #749

wants to merge 3 commits into from

Conversation

behrangsa
Copy link
Contributor

@klikh
Copy link
Member

klikh commented Mar 5, 2018

Have you submitted a contributor license agreement? If not, please follow the steps described at http://www.jetbrains.com/agreements/cla/ to sign it.

@behrangsa
Copy link
Contributor Author

Just signed it.

@tumasgiu
Copy link

This won't work if one happens to use functions in its ~/.config/fish/config.fish.
It works as expected if the block sourcing the functions is placed before the one loading the
~/.config/fish/config.fish

Fixes an issue in which functions defined in `~/.config/fish/functions/*.fish` might get referenced in `. ~/.config/fish/config.fish`.
@behrangsa
Copy link
Contributor Author

@tumasgiu Thanks for catching this issue. I updated the PR to address it.

@nazar-pc
Copy link

nazar-pc commented Apr 1, 2018

Just applied this patch locally and it works fine. Hope to see this merged before next release.

@nazar-pc
Copy link

@Traff, what prevents this from being merged? I'm a bit tired to manually patch files after each update.

@bmorris591
Copy link

Can we get this merged? This bug is really rather annoying!

@behrangsa
Copy link
Contributor Author

Judging by his activity log, it is possible that @Traff (the assignee) is on vacation.

@behrangsa
Copy link
Contributor Author

behrangsa commented Jun 23, 2018

@Elizaveta239 @bulenkov @vladsoroka @Traff any progress on this guys?

@zaypen
Copy link
Contributor

zaypen commented Jun 25, 2018

Hi @behrangsa
Can we take care of ~/.config/fish/conf.d/ as well, which is also a important part of configurations of fish, I think
https://fishshell.com/docs/current/index.html#initialization

@trofimander
Copy link
Contributor

Merged

SergeyZh pushed a commit that referenced this pull request Oct 9, 2020
It would be nice to inform users that private and final modifiers
on fields are redundant in classes marked with @value.

GitOrigin-RevId: 289644af74cecea9a4878f98b2850b07df692cb6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants