Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SVG patching for new logic in 241 #291

Closed
rock3r opened this issue Jan 31, 2024 · 1 comment
Closed

Update SVG patching for new logic in 241 #291

rock3r opened this issue Jan 31, 2024 · 1 comment
Assignees
@rock3r
Labels
bridge Something that impacts the Swing LaF bridge consistency Our UI presentation is not consistent with IJ release-blocker Issues that block a (stable) release of the library standalone Something that impacts the standalone theme
Milestone
Milestone 14

Comments

@rock3r
Copy link
Collaborator

rock3r commented Jan 31, 2024

In IJP 241, as of IDEA-342269, the logic to patch colors checkbox and radio button SVGs has changed. I am still trying to figure out the exact logic, but this requires at a minimum:

  • an update of the actual SVG files (which are at least now less wonky than they were!)
  • an update of the patching logic
  • an update of the validation outline size/offset to match the finally correct SVGs
  • confirming everything works

The first two should only affect standalone, since we use the patching as provided by the IDE for the bridge (always with the hope it's not terribly broken, which it maybe still is).
@rock3r rock3r added consistency Our UI presentation is not consistent with IJ release-blocker Issues that block a (stable) release of the library bridge Something that impacts the Swing LaF bridge standalone Something that impacts the standalone theme labels Jan 31, 2024
@rock3r rock3r added this to the Milestone 14 milestone Jan 31, 2024
@rock3r rock3r self-assigned this Jan 31, 2024
@rock3r rock3r mentioned this issue Feb 1, 2024
Merged
rock3r added a commit that referenced this issue Feb 8, 2024
@rock3r
#291 — Fix icons patching and theming issues in 241 (#293)
3398dd6 
Fix icon loading and errors in bridge for 241
@rock3r
Copy link
Collaborator Author

rock3r commented Feb 8, 2024

Fixed in #293

@rock3r rock3r closed this as completed Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rock3r rock3r

Labels
bridge Something that impacts the Swing LaF bridge consistency Our UI presentation is not consistent with IJ release-blocker Issues that block a (stable) release of the library standalone Something that impacts the standalone theme
Projects
None yet
Milestone
Milestone 14
Development

No branches or pull requests
1 participant
@rock3r