Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#291 — Fix icons patching and theming issues in 241 #293

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

rock3r
Copy link
Collaborator

@rock3r rock3r commented Feb 1, 2024

This PR fixes the SVG icons patching for checkboxes and radio buttons in 241 and on standalone, by:

  1. Using the SVGs from 241 in standalone, which are 10000% less wonky than the 23* ones
  2. Changing the patching logic for their colours to use the new ID-based one introduced in 241
  3. Fixing checkbox and radio button implementations to remove hacks and reliably work with the new logic/SVGs
  4. Resolve errors in bridge by following the hard deprecation notices' instructions
Before After
Before After

This closes #290

@rock3r rock3r added consistency Our UI presentation is not consistent with IJ release-blocker Issues that block a (stable) release of the library maintenance Rote maintenance tasks (e.g., dependency updates) labels Feb 1, 2024
@rock3r rock3r self-assigned this Feb 1, 2024
@rock3r
Copy link
Collaborator Author

rock3r commented Feb 2, 2024

EAP 3 is just out so I'm double checking everything just in case :)

@rock3r rock3r force-pushed the 291_fix-icons-patching-in-241 branch from 925b885 to a941970 Compare February 2, 2024 18:20
@rock3r
Copy link
Collaborator Author

rock3r commented Feb 2, 2024

One thing left to fix: checkboxes/radio buttons in classic UI themes (Darcula, High Contrast) don't get colours properly patched

@rock3r rock3r force-pushed the 291_fix-icons-patching-in-241 branch 3 times, most recently from 2ad160a to 685ba72 Compare February 7, 2024 14:14
@rock3r rock3r marked this pull request as ready for review February 7, 2024 14:14
@rock3r rock3r force-pushed the 291_fix-icons-patching-in-241 branch from 685ba72 to 668bab3 Compare February 7, 2024 14:17
@rock3r
Copy link
Collaborator Author

rock3r commented Feb 7, 2024

Verified to work on both standalone and IDE. Required fixes to the painter hints order, a buncha extra checks (e.g. only applying the new colour patching scope on New UI themes — that are, for now, hardcoded), and some other fun acrobatics. Obviously they also changed how the theme JSONs are represented in memory in 241, which broke old UI color patching.

I took the opportunity to add KDocs to a bunch of things and to test on Windows, too. I had to fix a few issues with bloody \r\n's and / vs , of course.

@rock3r rock3r removed the request for review from c5inco February 7, 2024 14:19
@rock3r rock3r changed the title #291 — Fix icons patching in 241 #291 — Fix icons patching and theming issues in 241 Feb 7, 2024
@rock3r rock3r force-pushed the 291_fix-icons-patching-in-241 branch from 668bab3 to d6f2df5 Compare February 7, 2024 17:07
@rock3r rock3r merged commit 3398dd6 into main Feb 8, 2024
8 checks passed
@rock3r rock3r deleted the 291_fix-icons-patching-in-241 branch February 8, 2024 10:42
rock3r added a commit that referenced this pull request Feb 12, 2024
Includes relevant changes from these PRs:
#290 — Add support for 241
#292 — Switch to the new branching strategy
#293 — Fix icon loading and errors in bridge for 241
#294 — Add Markdown renderer code and sample
@rock3r rock3r mentioned this pull request Feb 12, 2024
rock3r added a commit that referenced this pull request Feb 12, 2024
Includes relevant changes from these PRs:
#290 — Add support for 241
#292 — Switch to the new branching strategy
#293 — Fix icon loading and errors in bridge for 241
#294 — Add Markdown renderer code and sample
@rock3r rock3r mentioned this pull request Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consistency Our UI presentation is not consistent with IJ maintenance Rote maintenance tasks (e.g., dependency updates) release-blocker Issues that block a (stable) release of the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants