-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#291 — Fix icons patching and theming issues in 241 #293
Conversation
EAP 3 is just out so I'm double checking everything just in case :) |
925b885
to
a941970
Compare
One thing left to fix: checkboxes/radio buttons in classic UI themes (Darcula, High Contrast) don't get colours properly patched |
2ad160a
to
685ba72
Compare
685ba72
to
668bab3
Compare
Verified to work on both standalone and IDE. Required fixes to the painter hints order, a buncha extra checks (e.g. only applying the new colour patching scope on New UI themes — that are, for now, hardcoded), and some other fun acrobatics. Obviously they also changed how the theme JSONs are represented in memory in 241, which broke old UI color patching. I took the opportunity to add KDocs to a bunch of things and to test on Windows, too. I had to fix a few issues with bloody \r\n's and / vs , of course. |
668bab3
to
d6f2df5
Compare
This PR fixes the SVG icons patching for checkboxes and radio buttons in 241 and on standalone, by:
This closes #290