Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace compiler internal API with compiler main function call besides completion #709

Merged
merged 6 commits into from
Dec 28, 2023

Conversation

zhelenskiy
Copy link
Member

Second attempt for the reverted previous PR.

@zoobestik
Copy link
Collaborator

zoobestik commented Dec 13, 2023

There is some problems:

  • 1. line and ch plus 1 for:

    fun main() {
      dfsdf
    }
     { /* ... */ "start": { "line": 2, "ch": 3 }, /* ... */ }
  • 2. Not found main - <errStream>No main method found in project.\n</errStream>

    package org.kotlinlang.play
    
    fun main() {
      println("Hello, World!")
    }
  • 3. none some deprecation warnings

    fun main() {
      println("abc"[0].toInt())
    }

    Expected:
    toInt(): Int' is deprecated. Conversion of Char to Number is deprecated. Use Char.code property instead.

  • 4. no className for errors with severities (WARNING, ERROR):

    fun main() {
      val a: dynamic = "abc"
      println(a.charAt(1).repeat(3))     
    }

    Before:

    {"interval":{ /* ... */ }, "message": "..." , "severity": "ERROR", "className":"red_wavy_line" }

@zhelenskiy
Copy link
Member Author

zhelenskiy commented Dec 13, 2023

The second point is fixed.

zhelenskiy and others added 6 commits December 28, 2023 17:28
…. Also made changes to `CliUtils.kt` to handle error descriptors and text intervals correctly.
…ls.kt

Co-authored-by: Evgeniy Zhelenskiy <55230817+zhelenskiy@users.noreply.github.com>
Co-authored-by: Evgeniy Zhelenskiy <55230817+zhelenskiy@users.noreply.github.com>
@zoobestik zoobestik merged commit 1fd8b0e into JetBrains:master Dec 28, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants