Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom PSI module for external assembly definition files #702

Closed
citizenmatt opened this issue Aug 9, 2018 · 1 comment · Fixed by #2179
Closed

Custom PSI module for external assembly definition files #702

citizenmatt opened this issue Aug 9, 2018 · 1 comment · Fixed by #2179
Assignees
Labels
packages Unity package manager
Milestone

Comments

@citizenmatt
Copy link
Member

Resolve errors are currently disabled for .asmdef files (#701), as we can't resolve assembly definitions in .asmdef files external to the project, i.e. referenced packages and dependencies. To correctly resolve this, external .asmdef files need adding to a custom PSI module to make them available to the definition cache.

@citizenmatt citizenmatt added this to the Rider 2018.3 milestone Aug 9, 2018
@citizenmatt citizenmatt self-assigned this Aug 9, 2018
@citizenmatt citizenmatt added the packages Unity package manager label Aug 9, 2018
@citizenmatt
Copy link
Member Author

I think it would probably be better to create a new PSI module for each assembly definition in a package. This would fix this problem, and would also allow us to specify defines for the files in that package, known references, and provide much better navigation, etc. See #710

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages Unity package manager
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant