-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve support for .asmdef references, including GUID references #2179
Conversation
Fixes RIDER-58568
Also implements context highlighting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you check that JetBrains.ReSharper.Plugins.Unity.JsonNew.Feature.Services.Daemon.JsonNewLanguageSpecificDaemonBehavior is applicable for asmdef files? That behaviour suppresses swea for asmdef. We are not calculating any dependencies for asmdef files so reanalyze after changes is not working for asmdef files
resharper/resharper-unity/src/Core/Psi/Modules/UnityExternalFilesModuleProcessor.cs
Outdated
Show resolved
Hide resolved
Aha, yes, it applies. And we don't get any errors in SWEA if there's an error in a |
No, because asmdef is not supporting swea right now: if you create asmdef file with unknown guid, that error will be added to swea. After that, close that asmdef file and fix error by creating required asmdef, error will not disappear from solution-wide analysis, swea will not reanalyze first file, because we don't provide any info why the file should be reanalyzed |
We've got a file watcher on all external files, and push the PSI changes through the change builder, so we're updating caches (like we're doing with assets and scenes, etc.). Is that enough for SWEA, or does it need more? |
This PR builds on #2174 to improve support for
.asmdef
files. It's currently targeting that branch, but will automatically switch tonet213
when merged. Some minor conflicts will need to be addressed, since #2174 has moved on a little bit since this branch started..asmdef
file. Process files from all external packages #2174 now indexes all.asmdef
files from all packages, so we can resolve all references, even into builtin packages/modules. Fixes Custom PSI module for external assembly definition files #702.asmdef
files that are using name based references. The hint severity is configurable.