New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed end of php use on AUR API #1685
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me it's only working without this extra /
? Is it just me?
Works for me, i cloned it and build it and it works! |
It is indeed, I tested both and it's just redirecting so no problem in either case. However I prefered to strictly follow the doc which is using / everywhere : https://aur.archlinux.org/rpc (for what reason, I don't know) |
oh yeah, works now. I'm intermittently getting |
Tail slashes are now redirected to remove the tail slash at the end. However, this was never intended to count against any kind of rate limiting. Perhaps there is a sort of propagation issue here? |
Yes, I'm investigating. The /-adding commit seems to only break when trying to install a specific package from the AUR. The reason why is unknown to me as it is redirecting when testing directly. So far I only saw |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this works much better. Hope this can be fast-tracked. ;)
Can confirm these 3 commits fix the issue for me. Hopefully it gets merged so users can move to |
I'm going to patch in a temporary fix for you guys for now which restores that routes support. In a month, I'll remove it: https://gitlab.archlinux.org/archlinux/aurweb/-/commit/101de8e7b18916dd84ae52d39fb853924ea63a42 That'll give yay users some time to be able to upgrade. And... we'll go ahead and support the trailing slash for These changes will be deployed up to https://aur.archlinux.org on the morning of 02/05 (European timezone). We will be removing the temporary Edit: Thread started at https://lists.archlinux.org/pipermail/aur-general/2022-February/036787.html regarding these details. Edit2: Fixes rolled out. |
Seems a lot has happened in the last 13h 🙂 Thanks @kevr for introducing a small deprecation time. Thanks @mh4ckt3mh4ckt1c4s for the fast patch, I'll be merging it in and verify if anything else needs to be changed and thanks everyone for your patience |
Everything seems to be fine, I've updated aur lib to use the same endpoints. Expect a new release tomorrow |
What can I say except: |
This PR is related to #1682, #1684 and others. Fixing the changed AUR API endpoint who no longer use PHP and thus breaking yay -S.