Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed end of php use on AUR API #1685

Merged
merged 3 commits into from Feb 5, 2022
Merged

Fixed end of php use on AUR API #1685

merged 3 commits into from Feb 5, 2022

Conversation

mh4ckt3mh4ckt1c4s
Copy link
Contributor

This PR is related to #1682, #1684 and others. Fixing the changed AUR API endpoint who no longer use PHP and thus breaking yay -S.

Copy link

@nicola-sorace nicola-sorace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it's only working without this extra /? Is it just me?

@jonas-w
Copy link

jonas-w commented Feb 4, 2022

For me it's only working without this extra /? Is it just me?

Works for me, i cloned it and build it and it works!

@mh4ckt3mh4ckt1c4s
Copy link
Contributor Author

For me it's only working without this extra /? Is it just me?

It is indeed, I tested both and it's just redirecting so no problem in either case. However I prefered to strictly follow the doc which is using / everywhere : https://aur.archlinux.org/rpc (for what reason, I don't know)

@nicola-sorace
Copy link

nicola-sorace commented Feb 5, 2022

oh yeah, works now. I'm intermittently getting AUR is unavailable at this moment but I guess it's probably unrelated.
edit: Definitely happens more often with the slash though!

@kevr
Copy link

kevr commented Feb 5, 2022

oh yeah, works now. I'm intermittently getting AUR is unavailable at this moment but I guess it's probably unrelated. edit: Definitely happens more often with the slash though!

Tail slashes are now redirected to remove the tail slash at the end. However, this was never intended to count against any kind of rate limiting. Perhaps there is a sort of propagation issue here?

@mh4ckt3mh4ckt1c4s
Copy link
Contributor Author

oh yeah, works now. I'm intermittently getting AUR is unavailable at this moment but I guess it's probably unrelated. edit: Definitely happens more often with the slash though!

Yes, I'm investigating. The /-adding commit seems to only break when trying to install a specific package from the AUR. The reason why is unknown to me as it is redirecting when testing directly. So far I only saw AUR is unavailable at this moment with the /-adding commit. I might remove it, but I'd like to understand why this happens. Does somebody had the AUR error without the /-adding commit?

Copy link

@DonielMoins DonielMoins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this works much better. Hope this can be fast-tracked. ;)

@gardotd426
Copy link

Can confirm these 3 commits fix the issue for me. Hopefully it gets merged so users can move to yay-git until it makes a release. Or the AUR yay packager can add the 3 commits as patches. But yes, I can confirm that after cloning this repo and fetching this PR and using git format-patch to create 3 patches based on the commit, and adding them to the yay-git PKGBUILD, everything is back to normal.

@djvs
Copy link

djvs commented Feb 5, 2022

@kevr
Copy link

kevr commented Feb 5, 2022

I'm going to patch in a temporary fix for you guys for now which restores that routes support. In a month, I'll remove it: https://gitlab.archlinux.org/archlinux/aurweb/-/commit/101de8e7b18916dd84ae52d39fb853924ea63a42

That'll give yay users some time to be able to upgrade.

And... we'll go ahead and support the trailing slash for /rpc/ without redirects from now on: https://gitlab.archlinux.org/archlinux/aurweb/-/commit/0c1bd982ea0958722366bc5a1706becf810bd697

These changes will be deployed up to https://aur.archlinux.org on the morning of 02/05 (European timezone).

We will be removing the temporary /rpc.php/? endpoints in one month from now; i'll send out an aur-general announcement about this shortly.

Edit: Thread started at https://lists.archlinux.org/pipermail/aur-general/2022-February/036787.html regarding these details.

Edit2: Fixes rolled out.

@Jguer
Copy link
Owner

Jguer commented Feb 5, 2022

Seems a lot has happened in the last 13h 🙂

Thanks @kevr for introducing a small deprecation time.

Thanks @mh4ckt3mh4ckt1c4s for the fast patch, I'll be merging it in and verify if anything else needs to be changed

and thanks everyone for your patience

@Jguer
Copy link
Owner

Jguer commented Feb 5, 2022

Everything seems to be fine, I've updated aur lib to use the same endpoints.

Expect a new release tomorrow

@DonielMoins
Copy link

DonielMoins commented Feb 5, 2022

Expect a new release tomorrow

What can I say except:
Yay!

@Jguer Jguer mentioned this pull request Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants