Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Go 1.21's min/max built-ins #2405

Merged
merged 1 commit into from
Mar 23, 2024
Merged

Use Go 1.21's min/max built-ins #2405

merged 1 commit into from
Mar 23, 2024

Conversation

JRaspass
Copy link
Contributor

This simplifies the code compared to either rolling our own or awkwardly using math's float functions with integers.

@JRaspass
Use Go 1.21's min/max built-ins
5a55cde 
This simplifies the code compared to either rolling our own or awkwardly
using math's float functions with integers.
@JRaspass JRaspass requested a review from Jguer as a code owner March 19, 2024 03:37
Jguer
Jguer approved these changes Mar 23, 2024
View reviewed changes
Copy link
Owner

@Jguer Jguer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contribution @JRaspass

@Jguer Jguer merged commit 6c23305 into Jguer:next Mar 23, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jguer Jguer Jguer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JRaspass @Jguer