Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch : margin-top : Editor toolbar "sticky" to FullScreen #98

Merged
merged 2 commits into from
May 13, 2019

Conversation

sudwebdesign
Copy link
Contributor

If use margin-top rules in project to work gracefully :)
But, when clic on FullScreen button in "sticky" toolbar
big space before & after Sun toolbar on screen > 767px.

toolbar have "sun-editor-sticky" class & apply margin-top

  • the stickyDummy are visible

With this css rules:

.sun-editor-id-toolbar.sun-editor-common.sun-editor-sticky{
 margin-top: 13rem;
}

@media (max-width: 767px) {
 .sun-editor-id-toolbar.sun-editor-common.sun-editor-sticky{
  margin-top: 0;
 }
}

in minified
After: .zIndex="2147483647",
Add:
e.element._stickyDummy.style.display="none",
s.removeClass(n,"sun-editor-sticky"),

& it's good ;)

I use margin-top rules in PluXml project to work gracefully :)
But, when clic on FullScreen button in "sticky" toolbar

If editor is sticky & toggle to fullscreen mode:
big space before & after Sun toolbar on screen > 767px.

toolbar have "sun-editor-sticky" class & apply margin-top
+ the stickyDummy are visible

With this css rules:

```
.sun-editor-id-toolbar.sun-editor-common.sun-editor-sticky{
 margin-top: 13rem;
}

@media (max-width: 767px) {
 .sun-editor-id-toolbar.sun-editor-common.sun-editor-sticky{
  margin-top: 0;
 }
}
```

After .zIndex="2147483647"
ADD
e.element._stickyDummy.style.display="none",
s.removeClass(n,"sun-editor-sticky")

& it's all right ;)
@JiHong88
Copy link
Owner

Hi @sudwebdesign

Thanks for your contribution

@JiHong88 JiHong88 merged commit 2372372 into JiHong88:master May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants