Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove polling from SOCKS proxy #113

Closed
bemasc opened this issue Oct 9, 2018 · 0 comments
Closed

Remove polling from SOCKS proxy #113

bemasc opened this issue Oct 9, 2018 · 0 comments
Assignees
@bemasc
Labels
enhancement New feature or request network Network layer technical problem

Comments

@bemasc
Copy link
Contributor

bemasc commented Oct 9, 2018

Currently we have polling in a couple of places in the SOCKS proxy, inherited from Sockslib:

These polling loops exist primarily to detect an interrupt and perform a clean shutdown of the associated proxy pair.

This polling might be significantly increasing Intra's power usage. We should remove these polling loops and move to a fully event-driven threading design.
@bemasc bemasc added enhancement New feature or request network Network layer technical problem labels Oct 9, 2018
@bemasc bemasc self-assigned this Oct 9, 2018
bemasc pushed a commit that referenced this issue Oct 10, 2018
Remove polling from UDP proxy path
bec88bc 
This change probably won't have a major impact
on power consumption, but it's much easier than
the corresponding TCP change because it's already in
Intra code (not library code).

See #113
@bemasc bemasc mentioned this issue Oct 10, 2018
Merged
bemasc pushed a commit that referenced this issue Oct 10, 2018
Remove all polling from the SOCKS server
84273e9 
This change also essentially removes the socket idle timeout,
which is much less necessary now that idle sockets don't
consume CPU time.

Fixes #113
bemasc pushed a commit that referenced this issue Oct 10, 2018
Remove all polling from the SOCKS server
1b934eb 
This change also essentially removes the socket idle timeout,
which is much less necessary now that idle sockets don't
consume CPU time.

Fixes #113
@bemasc bemasc mentioned this issue Oct 10, 2018
Merged
bemasc pushed a commit that referenced this issue Oct 10, 2018
Remove all polling from the SOCKS server
ef32559 
This change also essentially removes the socket idle timeout,
which is much less necessary now that idle sockets don't
consume CPU time.

Fixes #113
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bemasc bemasc

Labels
enhancement New feature or request network Network layer technical problem
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bemasc