Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go-tun2socks connection error #1449

Closed
KilledDebtor opened this issue Oct 21, 2022 · 4 comments · Fixed by #1455
Closed

go-tun2socks connection error #1449

KilledDebtor opened this issue Oct 21, 2022 · 4 comments · Fixed by #1455

Comments

@KilledDebtor
Copy link

Error when i press connect.

`Outline is starting
loading web app from file:///C:/Program%20Files%20(x86)/Outline/resources/app.asar/www/index_electron.html?appName=Outline
Could not load active tunnel: [Error: ENOENT: no such file or directory, open 'C:\Users\aleks\AppData\Roaming\Outline\connection_store'] {
errno: -4058,
code: 'ENOENT',
syscall: 'open',
path: 'C:\Users\aleks\AppData\Roaming\Outline\connection_store'
}
Checking for update
Update for version 1.8.0 is not available (latest version: 1.7.1, downgrade is disallowed).
connecting to 6922b3b3-ac69-4269-8807-d5514ef951d0...
connectivity check failed: Error: Command failed: C:\Program Files (x86)\Outline\resources\app.asar.unpacked\third_party\outline-go-tun2socks\win32\tun2socks.exe -proxyHost 91.197.1.250 -proxyPort 38571 -proxyPassword wySVHEbJGTtr -proxyCipher chacha20-ietf-poly1305 -checkConnectivity

could not connect: f ()
tun2socks stopped with signal: null, code: null.
tun2socks stopped with signal: null, code: null.
disconnected from 6922b3b3-ac69-4269-8807-d5514ef951d0`

@KilledDebtor
Copy link
Author

Version 1.6.0 working well ...

@KilledDebtor KilledDebtor changed the title Windows 10 Connection error Windows 10 Connection error in 1.7.1 Oct 21, 2022
@jyyi1
Copy link
Contributor

jyyi1 commented Oct 24, 2022

This should be related to outline-go-tun2socks connection check. The server is reachable (using the old ss-local and tun2socks), but go-tun2sock reports that it is not. The error code is 4 UDPConnectivity, @bemasc can we ignore UDP connection issues during connectivity check?

@jyyi1 jyyi1 changed the title Windows 10 Connection error in 1.7.1 go-tun2socks connection error in 1.7.1 Oct 24, 2022
@jyyi1 jyyi1 changed the title go-tun2socks connection error in 1.7.1 go-tun2socks connection error Oct 24, 2022
@bemasc
Copy link
Contributor

bemasc commented Oct 24, 2022

The client code doesn't ignore UDP connection issues during connectivity check, but it intercepts them and uses them to adjust the configuration automatically. If this is failing, it's because the subprocess return code is being lost.

It would help to insert a debug check (or expanded log statement) in the client JS to confirm the exit code that is being observed by checkConnectivity() in node.

@jyyi1
Copy link
Contributor

jyyi1 commented Oct 24, 2022

Thanks @bemasc , I can take a deep look at the client logic.

jyyi1 added a commit that referenced this issue Oct 28, 2022
In this PR, I refactored `ChildProcessHelper` to use the async model when launching new child process, to replace the old event model. So the caller can get out the exit code more easily. As a side effect of this refactoring, I used `ChildProcessHelper` to implement the `checkConnectivity` feature in `GoVpnTunnel`, I also fixed #1449 by reading the exit code from `ChildProcessHelper`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants