refactor(electron): ♻️ use async model for ChildProcessHelper #1455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyyi1
force-pushed
the
junyi/fix-go-tunnel-exit-code
branch
from
69926a8
to
b4a4e96
Compare
jyyi1
force-pushed
the
junyi/fix-go-tunnel-exit-code
branch
from
b4a4e96
to
cdc6f05
Compare
fortuna
requested changes
Oct 27, 2022
jyyi1
force-pushed
the
junyi/fix-go-tunnel-exit-code
branch
from
4dc8ff3
to
d85907c
Compare
fortuna
approved these changes
Oct 28, 2022
| } catch (e) { | ||
| console.error(`tun2socks terminated due to ${e}`); | ||
| } | ||
| } while (!this.stopRequested && autoRestart); |
There was a problem hiding this comment.
You removed the nested start calls, nice! I was worried about the stack growth.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I refactored
ChildProcessHelperto use the async model when launching new child process, to replace the old event model. So the caller can get out the exit code more easily. As a side effect of this refactoring, I usedChildProcessHelperto implement thecheckConnectivityfeature inGoVpnTunnel, I also fixed #1449 by reading the exit code fromChildProcessHelper.