Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ssconf:// deeplinking on ios #1524

Merged
merged 16 commits into from
Jan 12, 2023
Merged

fix: ssconf:// deeplinking on ios #1524

Changes from 2 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
ddb6ec8
fix ssconf
daniellacosse Dec 21, 2022
631258e
oops
daniellacosse Dec 21, 2022
6f8cddd
feedback
daniellacosse Jan 5, 2023
09e9386
okay let's see how this does
daniellacosse Jan 6, 2023
29976fa
catch error
daniellacosse Jan 6, 2023
f9f5773
fine, this
daniellacosse Jan 6, 2023
5d46ecf
comment
daniellacosse Jan 6, 2023
44da5d7
ah yes typo
daniellacosse Jan 6, 2023
005e69e
Merge branch 'master' into daniellacosse/ios_ssconf_fix
daniellacosse Jan 6, 2023
2fff28d
Merge branch 'master' into daniellacosse/ios_ssconf_fix
daniellacosse Jan 9, 2023
5757d36
address feedback 2
daniellacosse Jan 10, 2023
bcb9d07
Update src/www/app/app.ts
daniellacosse Jan 12, 2023
d35996b
Update src/www/app/app.ts
daniellacosse Jan 12, 2023
f426381
Update src/www/app/app.ts
daniellacosse Jan 12, 2023
a44c1af
Update app.ts
daniellacosse Jan 12, 2023
af7d693
Merge branch 'master' into daniellacosse/ios_ssconf_fix
daniellacosse Jan 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/www/app/app.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -591,7 +591,7 @@ export class App {

private registerUrlInterceptionListener(urlInterceptor: UrlInterceptor) {
urlInterceptor.registerListener(url => {
if (!url || !unwrapInvite(url).startsWith('ss://')) {
if (!url || !(unwrapInvite(url).startsWith('ss://') || unwrapInvite(url).startsWith('ssconf://'))) {
daniellacosse marked this conversation as resolved.
Show resolved Hide resolved
daniellacosse marked this conversation as resolved.
Show resolved Hide resolved
// This check is necessary to ignore empty and malformed install-referrer URLs in Android
// while allowing ss:// and invite URLs.
// TODO: Stop receiving install referrer intents so we can remove this.
Expand Down