fix: ssconf:// deeplinking on ios #1524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyyi1
approved these changes
Dec 21, 2022
That would be great, but would require a lot of build work - these values need to be interpolated into several plists/config files |
fortuna
requested changes
Dec 21, 2022
fortuna
requested changes
Jan 4, 2023
|
I believe I am not making myself well understood, let's discuss this
offline.
…On Wed, Jan 4, 2023, 18:49 Vinicius Fortuna ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In src/www/app/app.ts
<#1524 (comment)>
:
> @@ -591,7 +591,7 @@ export class App {
private registerUrlInterceptionListener(urlInterceptor: UrlInterceptor) {
urlInterceptor.registerListener(url => {
- if (!url || !unwrapInvite(url).startsWith('ss://')) {
+ if (!url || !(unwrapInvite(url).startsWith('ss://') || unwrapInvite(url).startsWith('ssconf://'))) {
I believe my suggestions are straightforward, and they fix bugs that your
change is not fixing. I already did the work of finding the places to fix
for you.
At a minimum, the two lines I mention above must be fixed. That will be
cleaner if you define IsOutlineAccessKey(). The tests should be
straightforward too, we already have them set up.
We also need to make sure the fixed unwrap is not breaking names for
dynamic keys.
—
Reply to this email directly, view it on GitHub
<#1524 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA4V5VEUSHIPR56WVTZGASLWQYEBHANCNFSM6AAAAAATFYUQSY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
fortuna
approved these changes
Jan 5, 2023
fortuna
reviewed
Jan 5, 2023
fortuna
reviewed
Jan 5, 2023
|
(just reconfirmed it still works for ssconf:// after the refactor) |
fortuna
requested changes
Jan 10, 2023
fortuna
approved these changes
Jan 12, 2023
Co-authored-by: Vinicius Fortuna <fortuna@users.noreply.github.com>
Co-authored-by: Vinicius Fortuna <fortuna@users.noreply.github.com>
Co-authored-by: Vinicius Fortuna <fortuna@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.