fix: temporarily remove client feedback view #1548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bemasc
reviewed
Jan 12, 2023
| @@ -343,10 +343,11 @@ export class AppRoot extends mixinBehaviors([AppLocalizeBehavior], PolymerElemen | |||
| <iron-icon icon="outline-icons:outline" slot="item-icon"></iron-icon> | |||
| <span class="item-label">[[localize('servers-menu-item')]]</span> | |||
| </paper-icon-item> | |||
| <paper-icon-item name="feedback"> | |||
| <!-- TODO(daniellacosse): fix sentry and restore feedback view --> | |||
There was a problem hiding this comment.
In Outline we usually don't use TODO(username). I guess it's fine, but maybe TODO(bug number) would be better.
There was a problem hiding this comment.
There was a problem hiding this comment.
I use TODO(username), but I agree that a bug is more useful.
fortuna
approved these changes
Jan 12, 2023
bemasc
approved these changes
Jan 12, 2023
daniellacosse
added a commit
that referenced
this pull request
Jan 19, 2023
This reverts commit 539c002.
daniellacosse
added a commit
that referenced
this pull request
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't work and we need to fix it.