Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(devtools): simplify commitlint and update CODEOWNERS #2082

Merged
merged 3 commits into from
Jul 31, 2024

Conversation

daniellacosse
Copy link
Contributor

No description provided.

@daniellacosse daniellacosse requested a review from a team as a code owner July 30, 2024 20:30
'service/windows',
'storybook',
'www',
'storybook'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove storybook too? You're either working on the client, the manager, or if it's the storybook infra I'd argue that's a devtools thing?

Copy link
Contributor

@sbruens sbruens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big +1 to removing the electron/cordova part. This is much better.

Defer to Vini on the CODEOWNERS changes.

@daniellacosse
Copy link
Contributor Author

@fortuna I spoke to @sbruens and we're gonna merge this as is, we can put up another PR if there's an issue

@daniellacosse daniellacosse merged commit 47223f1 into master Jul 31, 2024
20 of 21 checks passed
@daniellacosse daniellacosse deleted the daniellacosse/update_commitlint_and_codeowners branch July 31, 2024 15:23
jyyi1 pushed a commit that referenced this pull request Aug 2, 2024
* fix(devtools): simplify commitlint and update CODEOWNERS

* Update commitlint.config.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants