-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(manager): implement separate server stat card grid in the storybook #2084
Conversation
</p> | ||
<p class="stat-card-name"> | ||
${this.name} | ||
</p>` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm surprised the linter isn't picking up on things like a missing semi-colon. Or is it not playing nicely with Lit. Do you know?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmmmmm I don't think eslint is enforcing semicolons. Frankly our linting could probably use an overhaul, but these sorts of things are notoriously difficult to get alignment on. I have configurations that I like - maybe we can start there? https://github.com/daniellacosse-code/promptspinner.com/blob/main/.eslintrc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think alignment should be an issue these days. The official style guides are pretty comprehensive. Anyway I was mostly curious if I was missing something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wait, is there an official google eslint config? can we extend that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/google/eslint-config-google seems a little unmaintained 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was talking about the style guide, not tooling. But if we did want to look at tooling it seems https://github.com/google/gts might be more up to date?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right - sorry that I didn't fully explain my train of thought there - I was thinking there must be a tool to enforce our official style guide, and it turns out there is!! And you found it!
Not actually using it in the app yet. This is a prototype for how the updated server metrics could look. Can always delete later.
Resizing
Screen.Recording.2024-08-01.at.8.57.50.AM.mov
Editing the grid
Screen.Recording.2024-08-01.at.9.09.42.AM.mov