fix(server): don't output all log messages #1232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fortuna
changed the title
daniellacosse
approved these changes
Nov 28, 2022
| export function error(message: string) { | ||
| console.error(makeLogMessage('E', getCallsite(), message)); | ||
| if (LogLevel.ERROR <= maxMsgLevel) { |
There was a problem hiding this comment.
another nit but personally i would short circuit on the inverse so the function main has a body. rn this reads "only do something if you're in the correct log level" rather than the inverse "do something unless you're not"
There was a problem hiding this comment.
I find it more readable to see the condition for which the code applies. I'd agree with you if there were multiple conditions to escape, to avoid nesting.
There was a problem hiding this comment.
fair enough, i agree this is rather subjective. just think that a function should do something by default, if you call it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is polluting the log output. I need to fix this asap.