Add early length check

Jigsaw-Code · Oct 5, 2020 · 2b2558d · 2b2558d
1 parent 5f16090
commit 2b2558d
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/shadowsocks/packet.go b/shadowsocks/packet.go
@@ -33,6 +33,9 @@ var zeroNonce [12]byte
 // function will panic.
 func Pack(dst, plaintext []byte, cipher shadowaead.Cipher) ([]byte, error) {
 	saltSize := cipher.SaltSize()
+	if len(dst) < saltSize {
+		return nil, io.ErrShortBuffer
+	}
 	salt := dst[:saltSize]
 	if err := RandomSaltGenerator.GetSalt(salt); err != nil {
 		return nil, err