Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update statuses #66

Merged
merged 8 commits into from
Sep 26, 2024
Merged

Update statuses #66

merged 8 commits into from
Sep 26, 2024

Conversation

calebbourg
Copy link
Collaborator

Description

This PR adds two new endpoings:

  • PUT actions/:id/status
  • PUT overarching_goals/:id/status

As well as the API plumbing to utilize the endpoints for updating status columns

GitHub Issue: [Closes|Fixes|Resolves] #your GitHub issue number here

Changes

  • Adds PUT actions/:id/status
  • Adds PUT overarching_goals/:id/status

@calebbourg calebbourg changed the base branch from main to delete_agreement September 25, 2024 08:29
@calebbourg calebbourg self-assigned this Sep 25, 2024
@calebbourg calebbourg added the feature work Specifically implementing a new feature label Sep 25, 2024
@@ -19,3 +19,15 @@ impl std::default::Default for Status {
Self::InProgress
}
}

impl From<&str> for Status {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition!

Copy link
Member

@jhodapp jhodapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, thanks for this! One change needed is to add the new controller methods to the openapi path macro in router.rs.

Base automatically changed from delete_agreement to main September 25, 2024 14:36
@calebbourg
Copy link
Collaborator Author

@jhodapp added! 0be8456

That one macro is going to be the death of me haha. For some reason it always slips my mind.

Copy link
Member

@jhodapp jhodapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic, thank you!

@calebbourg calebbourg merged commit c54ffb8 into main Sep 26, 2024
4 checks passed
@calebbourg calebbourg deleted the update_statuses branch September 26, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature work Specifically implementing a new feature
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants