Problem: tests are broken

[sevein]

Some fixes to get our tests working again inside Docker:

• storage_service.settings.test: disable whitenoise
• locations/fixtures/package.json: use json empty document default
• Dockerfile: add p7zip missing dependency
• Dockerfile: add workdir
• Dockerfile: add pythonpath

This is how you can run them to verify the fixes:

$ docker-compose run --rm --no-deps --entrypoint pytest \
	-e "DJANGO_SETTINGS_MODULE=storage_service.settings.test" \
		archivematica-storage-service

You can pass arguments to pytest, e.g.:

$ docker-compose run --rm --no-deps --entrypoint pytest \
	-e "DJANGO_SETTINGS_MODULE=storage_service.settings.test" \
		archivematica-storage-service \
			-x locations/tests/test_api.py

... meaning that you want to run only the tests under test_api.py and stop the process after hitting the first failing test.

[sevein]

Empty string is not a valid JSON document, causing the fixture loader to break. This probably started happening when we updated jsonfield.

[jhsimpson]

To run the docker-compose command you suggest, is it necessary to be testing from the rdss-archivematica repo?

I don't see a docker-compose.yml in this PR.

[sevein]

From compose/, but there is a PR in rdss-archivematica/ with a commit in it that adds a helpers/test-ss.sh shortcut.

[sevein]

Although I agree I should share an example to run directly with docker run in this repo. I will!

[sevein]

This should work:

$ docker run --rm --entrypoint pytest \
    --env "DJANGO_SETTINGS_MODULE=storage_service.settings.test" \
    --env "SS_DB_NAME=_" \
    --env "SS_DB_USER=_" \
    --env "SS_DB_PASSWORD=_" \
    --env "SS_DB_HOST=_" \
    --env "DJANGO_SECRET_KEY=_" \
    --env "DJANGO_ALLOWED_HOSTS=_" \
    --user "root" ss

But I'll make a couple of changes so we don't need root and all the extra environment strings. I shouldn't use get_env_variable in base.py but in the modules importing base. 🤦‍♂️

[sevein]

I've reviewed this with @jhsimpson IRL. The issue discussed above has been captured here: #9.

[jhsimpson]

I did get the tests to pass. I had to do

$ docker build -t ss .

before running the docker-compose command @sevein suggested above:

$ docker run --rm --entrypoint pytest \
    --env "DJANGO_SETTINGS_MODULE=storage_service.settings.test" \
    --env "SS_DB_NAME=_" \
    --env "SS_DB_USER=_" \
    --env "SS_DB_PASSWORD=_" \
    --env "SS_DB_HOST=_" \
    --env "DJANGO_SECRET_KEY=_" \
    --env "DJANGO_ALLOWED_HOSTS=_" \
    --user "root" ss

the output was

============================= test session starts ==============================
platform linux2 -- Python 2.7.13, pytest-3.1.2, py-1.4.34, pluggy-0.4.0
Django settings: storage_service.settings.test (from environment variable)
rootdir: /src/storage_service, inifile: pytest.ini
plugins: django-3.1.2, cov-2.4.0
collected 103 items

administration/tests/test_languages.py ....
locations/tests/test_api.py .............................
locations/tests/test_arkivum.py ......
locations/tests/test_dataverse.py ....
locations/tests/test_dspace.py .........
locations/tests/test_duracloud.py .................
locations/tests/test_fixity_log.py .
locations/tests/test_locations.py ...
locations/tests/test_lockssomatic.py .
locations/tests/test_package.py ..........
locations/tests/test_swift.py ..........
storage_service/tests/test_shibboleth.py sssss
storage_service/tests/test_startup.py ....

=============================== warnings summary ===============================
locations/tests/test_fixity_log.py::TestFixityLog::test_has_required_attributes
  /usr/local/lib/python2.7/site-packages/django/db/models/fields/__init__.py:1474: RuntimeWarning: DateTimeField FixityLog.datetime_reported received a naive datetime (2015-12-15 03:00:05.020871) while time zone support is active.
    RuntimeWarning)
  /usr/local/lib/python2.7/site-packages/_pytest/warnings.py:82: UnicodeWarning: Warning is using unicode non convertible to ascii, converting to a safe representation:
    /usr/local/lib/python2.7/site-packages/django/db/models/fields/__init__.py:1474: RuntimeWarning: DateTimeField FixityLog.datetime_reported received a naive datetime (2015-12-15 03:00:05.020871) while time zone support is active.
    RuntimeWarning)
  
    UnicodeWarning)

-- Docs: http://doc.pytest.org/en/latest/warnings.html
============== 98 passed, 5 skipped, 2 warnings in 12.12 seconds ===============

👍