Allow custom device id chooser function to be provided as prop #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When zero devices matches the wanted `facingMode`, the first video device found is chosen. That might not always be the wanted behaviour. These changes allows a custom function to be provided in the `chooseDeviceId` prop on the `<QrReader>` component. That function will allowed to choose which device should be used of the possibly matched video devices or all the video devices discovered. The default behaviour stays as before, so this has no effect on projects that doesn't provide the `chooseDeviceId` prop.
phillipj
force-pushed
the
use-last-device
branch
from
8ef4598
to
8d94b6f
Compare
|
👍 Looks good on first sight, i'll test it out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When zero devices matches the wanted
facingMode, the first video device found is chosen. That might not always be the wanted behaviour. In a project I'm working, it seems we consistently has to choose the last device.These changes allows a custom function to be provided in the
chooseDeviceIdprop on the<QrReader>component. That function will allowed to choose which device should be used of the possibly matched video devices or all the video devices discovered.The default behaviour stays as before, so this has no effect on projects that doesn't provide the
chooseDeviceIdprop.Any thoughts?